Skip to content

Add support for OZMO 905 (2pv572) and 900 (ls1ok3)#934

Merged
edenhaus merged 6 commits into
DeebotUniverse:devfrom
nanomad:feature/2pv572-hardware-definition
Apr 30, 2025
Merged

Add support for OZMO 905 (2pv572) and 900 (ls1ok3)#934
edenhaus merged 6 commits into
DeebotUniverse:devfrom
nanomad:feature/2pv572-hardware-definition

Conversation

@nanomad

@nanomad nanomad commented Apr 29, 2025 •
edited by edenhaus
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.03%. Comparing base (9e7c8df) to head (7b51a86).
Report is 2 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #934      +/-   ##
==========================================
+ Coverage   93.01%   93.03%   +0.01%     
==========================================
  Files         125      126       +1     
  Lines        4885     4899      +14     
  Branches      318      318              
==========================================
+ Hits         4544     4558      +14     
  Misses        282      282              
  Partials       59       59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #934 will not alter performance

Comparing nanomad:feature/2pv572-hardware-definition (7b51a86) with dev (e034f4c)

Summary

✅ 6 untouched benchmarks

@edenhaus edenhaus changed the title Add definition for 2pv572 (OZMO 905) Add support for 2pv572 (OZMO 905) Apr 29, 2025
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Apr 29, 2025
@nanomad

nanomad commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

@edenhaus Please do not merge yet. I've found two bugs in the core implementation. I'll open two urgent PR

@nanomad nanomad marked this pull request as draft April 29, 2025 08:21
@edenhaus edenhaus added the pr: Breaking Change Pull request with braking changes label Apr 29, 2025
@nanomad

nanomad commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

Blocked by #935

@nanomad

nanomad commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

@flubshi What's the difference between your bot and mine? Just the mopping capability? If so I can quickly open a PR for yours as well linking it to mine for now

@nanomad nanomad force-pushed the feature/2pv572-hardware-definition branch from 149783b to ea76824 Compare April 29, 2025 10:23
@flubshi

flubshi commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

@flubshi What's the difference between your bot and mine? Just the mopping capability? If so I can quickly open a PR for yours as well linking it to mine for now

Yes, as far as I know it is only mopping. In the past I used your bot config and removed the water box.
Since it is not yet implemented in master, you can for now link to your config imo.

@nanomad

nanomad commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

@flubshi What's the difference between your bot and mine? Just the mopping capability? If so I can quickly open a PR for yours as well linking it to mine for now

Yes, as far as I know it is only mopping. In the past I used your bot config and removed the water box. Since it is not yet implemented in master, you can for now link to your config imo.

Nice, feel free to test this branch, remember to merge in #935 as well or it won't work properly

edenhaus
edenhaus requested changes Apr 29, 2025
View reviewed changes
Comment thread deebot_client/hardware/deebot/ls1ok3.py
@edenhaus edenhaus removed the pr: Breaking Change Pull request with braking changes label Apr 30, 2025
@edenhaus edenhaus changed the title Add support for 2pv572 (OZMO 905) Add support for OZMO 905 (2pv572) and 900 (ls1ok3) Apr 30, 2025
@edenhaus edenhaus marked this pull request as ready for review April 30, 2025 09:18
edenhaus
edenhaus approved these changes Apr 30, 2025
View reviewed changes

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanomad 👍

@edenhaus edenhaus enabled auto-merge (squash) April 30, 2025 09:19
@edenhaus edenhaus merged commit 64fb815 into DeebotUniverse:dev Apr 30, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edenhaus edenhaus edenhaus approved these changes

Assignees

No one assigned

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nanomad @flubshi @edenhaus